Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHINENG-8881): Add bootc card host detail page #2168

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

dkuc
Copy link
Contributor

@dkuc dkuc commented Mar 26, 2024

Adds a new card with bootc system information. It is hidden when the system is not a bootc system.
image

Note to reviewers: Feel free to make changes directly. Close and reopen a new PR if needed. While I do believe this works and can be merged, its purpose is to imply intent.

@dkuc dkuc requested a review from a team as a code owner March 26, 2024 16:34
@dkuc dkuc force-pushed the add_bootc_host_info branch from fc8b754 to fd43bfd Compare March 26, 2024 16:35
@computercamplove
Copy link
Contributor

Hey @dkuc !

  1. could you please link a jira-card with acceptance criteria?
  2. I didn't see this in mock-ups - i saw this version shared by Andy Burka, what is right one? i will link it in slack and ask Andy

image

@dkuc
Copy link
Contributor Author

dkuc commented Mar 27, 2024

@computercamplove Yes, that is the correct mock.

@mkholjuraev
Copy link
Contributor

@dkuc the commits need to comply with the commit lint. The title should be similar to this:
${ type }( #ticket_number_in_Jira ): a short description explaining the changes you have made in this commit

For more info: https://docs.google.com/document/d/1BsZJXN2ygd-dOAN6IEpkPp-oQUoh4nHbtFLre6D5JoM/edit#heading=h.rt93vzt2dkoh

@computercamplove
Copy link
Contributor

fyi main part is working as expected - this card in host's details i see only for image-mode systems, thank you!

yet i still have some questions to clarify about card name and URL link - i left question in jira for Andy and Christopher https://issues.redhat.com/browse/RHINENG-8881.

@computercamplove
Copy link
Contributor

/retest

@computercamplove
Copy link
Contributor

got clarifications - this UI is expected for the first iteration (more info in card https://issues.redhat.com/browse/RHINENG-8881)
tested on local env and it works as expected

fyi @mkholjuraev

@@ -0,0 +1,56 @@
import React from 'react';
import PropTypes from 'prop-types';
import { connect } from 'react-redux';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although connect function is still supported, it is recommended to use the hooks API in recent versions of Redux. In this functional component, mainly data is read from the redux store. Thus, useSelector hook may be used for this purpose. Let me know if I should help by implementing this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkholjuraev Yes, help with this would be appreciated.

@dkuc dkuc changed the title Add bootc card host detail page feat(XXX-0000) Add bootc card host detail page Mar 28, 2024
@dkuc dkuc changed the title feat(XXX-0000) Add bootc card host detail page feat(XXX-0000): Add bootc card host detail page Mar 28, 2024
@dkuc dkuc force-pushed the add_bootc_host_info branch from e6f194d to fb11528 Compare March 28, 2024 14:29
@computercamplove
Copy link
Contributor

/retest

@dkuc dkuc changed the title feat(XXX-0000): Add bootc card host detail page feat(RHINENG-8881): Add bootc card host detail page Mar 29, 2024
@computercamplove
Copy link
Contributor

/retest

@computercamplove
Copy link
Contributor

computercamplove commented Apr 2, 2024

FYI @mkholjuraev, @dkuc i added test specific for this PR, it passed. Ignore test_filter_hosts_by_os

@gkarat gkarat requested review from mkholjuraev and a team April 2, 2024 10:22
@gkarat gkarat assigned gkarat and dkuc and unassigned gkarat Apr 2, 2024
@gkarat gkarat added the enhancement New feature or request label Apr 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 43.04%. Comparing base (f7ae6d7) to head (0d2b52d).

Files Patch % Lines
...nents/GeneralInfo/BootcImageCard/BootcImageCard.js 30.00% 7 Missing ⚠️
...neralInfo/GeneralInformation/GeneralInformation.js 50.00% 1 Missing ⚠️
src/components/SystemDetails/GeneralInfo.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
- Coverage   43.68%   43.04%   -0.64%     
==========================================
  Files         198      199       +1     
  Lines        6286     6300      +14     
  Branches     1759     1764       +5     
==========================================
- Hits         2746     2712      -34     
- Misses       3540     3588      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested with 'image-mode-test-60e1ea67' bootc system and other non bootc systems.

@mkholjuraev mkholjuraev merged commit 63bd361 into RedHatInsights:master Apr 2, 2024
1 of 2 checks passed
@gkarat
Copy link
Contributor

gkarat commented Apr 2, 2024

🎉 This PR is included in version 1.67.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants